Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r18832 - trunk/apps

Re: jdgordon: r18832 - trunk/apps

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sun, 26 Oct 2008 17:15:22 +1100

2008/10/24 Dave Chapman <dave_at_dchapman.com>:
> mailer_at_svn.rockbox.org wrote:
>>
>> Date: 2008-10-19 05:58:33 +0200 (Sun, 19 Oct 2008)
>> New Revision: 18832
>>
>> Log Message:
>> Dont show lines which have no info in the id3 viewer screen.
>>
>>
>> Modified:
>> trunk/apps/screens.c
>
> Why was this feature change committed without any pre-commit discussion at
> all? It has since been questioned a few times in IRC.

FS#8955 has been on the tracker since May, it was discussed in IRC
since then (I don't remember exactly when).

>
> IMO it's not obvious that this is an improvement - it can be useful to
> see the list of tags that Rockbox supports, and which ones are missing on a
> particular file. So that screen serves two purposes - to see what the tags
> are, and to see what tags are missing.

A number of devs preach in the forums and IRC about when tasks are
better suited to your PC that they should be done there, checking tags
(especially missing ones) are without question better suited to the PC
and here is why:
1) Rockbox will never support every possible tag in each container
format, so why bother showing only a subset of missing tags?
2) Everyone is always going on about getting the best use out of the
tiny screens, filling it with <No Info> lines are definetly not a good
use for the screen space
3) whats the point of knowing the tags are missing unless you can fix
them? We lack a tag editor... if/when one ever comes along then
*maybe* there will be an argument for this

Jonathan
Received on 2008-10-26


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa