Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: funman: r19043 - in trunk/firmware: export target/arm

Re: funman: r19043 - in trunk/firmware: export target/arm

From: Frank Gevaerts <frank_at_gevaerts.be>
Date: Sun, 9 Nov 2008 15:32:41 +0100

On Sun, Nov 09, 2008 at 07:17:14AM +0100, mailer_at_svn.rockbox.org wrote:
> Date: 2008-11-09 07:17:14 +0100 (Sun, 09 Nov 2008)
> New Revision: 19043
>
> Log Message:
> SD PP: move non specific defines to sd.h, to be reused by other SD drivers

Good idea, but since sd.h is (inderectly) included in not directly
related code, I think the defines should be prefixed with SD_

Frank

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
Received on 2008-11-09

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa