On Sun, Nov 9, 2008 at 22:09, Rafaël Carré <rafael.carre_at_gmail.com> wrote:
>
> On Sun, Nov 09, 2008, Frank Gevaerts wrote:
> > On Sun, Nov 09, 2008 at 07:17:14AM +0100, mailer_at_svn.rockbox.org wrote:
> > > Date: 2008-11-09 07:17:14 +0100 (Sun, 09 Nov 2008)
> > > New Revision: 19043
> > >
> > > Log Message:
> > > SD PP: move non specific defines to sd.h, to be reused by other SD drivers
> >
> > Good idea, but since sd.h is (inderectly) included in not directly
> > related code, I think the defines should be prefixed with SD_
>
> That's better to use a SD_ namespace, I will correct that and also look
> at using these defines in the ingenic jz47xx target

About the Jz47xx targets: currently the SD code is not working,
meaning it's probably going to change; so you probably don't want to
base your defines on the current code.

Cuelenaere Maurus
Received on 2008-11-09