Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Backlight fading settings

Re: Backlight fading settings

From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Date: Mon, 12 Jan 2009 23:44:56 +0100

On Mon, Jan 12, 2009 at 10:37 PM, Thomas Martitz
<thomas.martitz_at_fhtw-berlin.de> wrote:
> This part is what I'm unsure about in our case. I see a number of people
> liking the backlight fading time configurability. But, based on the opinions
> some people on IRC threw in (they basically all said they don't change the
> defaults), I see the majority of people keeping the values at their
> defaults.

How about the majority of users? I bet those haven't been asked, and
even if you'd only get the opinions of those (most likely few) that
actually raise their voice, thus making a poll about this most likely
nothing near to representative.
Besides, the people discussing things on IRC are in most cases
developers, and its quite common that developers have noticably
different views than users.

> On the other hand, the few people at #rockbox that stated their opinion are
> representative at all, so my impression can be wrong. But it at least shows
> that the current defaults (short fade in, long'ish fade out) are not
> entirely wrong, I'd even they say are well chosen (I wouldn't change that
> behavior either).

The people at #rockbox are representative? For what group? Since when
is an arbitrary group of people representative? Also, I remember quite
some discussion (without a consensus) about what values are to be
reasonable defaults.

> Dominik, what values do you prefer?

the values depend on target, thus it doesn't make much sense
discussing them here. Also, I'm pretty sure most people would choose
others.

To go back to the main point: if the code handling the fading settings
is in fact too complex (but why? You have the values anyway, and why
should it make that much of a difference if the value is adjusted and
taken from a variable in the code instead of being a #define?) it
would be much better to make the code less complex instead of simply
scrapping features -- given the feature in question is actually useful
and used, which definitely is the case here.

 - Dominik
Received on 2009-01-12


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa