Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Backlight fading settings

Re: Backlight fading settings

From: Björn Stenberg <bjorn_at_haxx.se>
Date: Tue, 13 Jan 2009 10:10:52 +0100

Dominik Riebeling wrote:
> Also, those settings have been there since years and I don't see a
> point in removing them at all.

The point is that the fading code is ballooning. As we add the feature on more targets, we have to add more conditions and settings due to different targets implementing it differently.

We currently have no less than four configuration defines dealing with backlight fading:

#define HAVE_BACKLIGHT_PWM_FADING
#define HAVE_BACKLIGHT_SET_FADING
#define USE_BACKLIGHT_CUSTOM_FADING_BOOL
#define USE_BACKLIGHT_SW_FADING

We also have four different settings for it.

Changing the backlight fading times is such a micro-management option that I think it simply is not useful enough to warrant the mess it causes. I'd go so far as call it configuration in absurdum.

The parallell question I like to ask is: If this is so important, why don't we have a time setting (or two!) for the fade-on-stop feature?

-- 
Björn
Received on 2009-01-13

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa