Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: kugel: r19826 - trunk/wps

Re: kugel: r19826 - trunk/wps

From: Dave Chapman <dave_at_dchapman.com>
Date: Sat, 24 Jan 2009 04:37:47 +0000

mailer_at_svn.rockbox.org wrote:
> Date: 2009-01-23 19:34:06 +0100 (Fri, 23 Jan 2009)
> New Revision: 19826
>
> Log Message:
> Fix wpsbuild.pl not installing all required fonts

Even though it turns out that it was due to a bug, I had always thought
that the behaviour of only including the font required by the default
theme was intentional. This commit changes that behaviour to include
the fonts required by all included themes - including the 2MB unifont on
many targets.

When the fonts were split from the main zip, the reason was to remove
the virtually static fonts from the ever-changing rockbox.zip. This
meant that some shipped themes didn't include their fonts, but users
have always been told that a first-time involves installing both the
main zip and the fonts. To quote the manual:

"The fonts package rarely changes and is therefore not included in the
firmware .zip file. When installing Rockbox for the first time, you
should install the fonts package."

Users who don't install the fonts package will run into problems soon
enough anyway - when they try and install third-party themes - so I
don't think that reverting the original fonts split to include the fonts
for all shipped themes gains us anything, apart from larger downloads
for everyone, and longer install times when extracting the zip to the
device.

Regards,

Dave.
Received on 2009-01-24


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa