Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: New patch: Add "use morse input " entry to settings menu

New patch: Add "use morse input " entry to settings menu

From: David Johnston <david_at_pinkandaint.com>
Date: Mon, 15 Jun 2009 09:13:26 -0700

I just put up a new patch, my first forray into RB development. It's
pretty straigtforward, simply adding an entry to the menu system to
set whether the user wants to use the morse code input screen rather
than the standard one. I think it would be a good addition to the
codebase, since it creates a more intuitive way to switch screens, as
well as saving the user's preference of which screen to use across
sessions.

I would welcome feedback on functionality as well as menu item text
and placement. So far I've only tested it on h120 but I imagine there
would be no trouble compiling it for other platforms. I made an
effort to follow all the necessary precautions with conditional
compiling and so on.

Below is the official description in the Flyspray entry
(http://www.rockbox.org/tracker/task/10338).

-David

---
This patch adds an entry to the settings menus to set whether the user
wants to use the morse code text input screen rather than the main
keyboard screen. An entry in the general_settings struct now holds the
current morse input bool.
As a result of this change, whenever the user changes between the
morse and standard text input screens -- either through the menu or
the key combo while inputting text -- Rockbox will remember that
setting across sessions. This makes the menu item a somewhat redundant
feature, but still valuable since it doesn't require remembering an
obscure key combination to change text input style.
I applied this patch to revision 21293, but should be generally applicable.
Received on 2009-06-15

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa