Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r21307 - trunk/apps

Re: jdgordon: r21307 - trunk/apps

From: pondlife <pondlife_at_ntlworld.com>
Date: Wed, 17 Jun 2009 09:51:53 +0100

> 1) it means alot of work, there are IIRC 800+ splashes in the code
> atm, every one will need to be fixed to make sure they work as
> expected (the very least each will need is to add a "action = " before
> every splash call

The splash() simply leaves the button in the queue and returns so the
calling code should not need any changes.

> 2) I would think it would lead to more confusion if you are looking at
> the screen... especially if you go into a splash loop (which would be
> trivial to do... just keep pressing SELECT...)

Try it (first attempt at a patch is now on FS#10322). I don't find it
confusing at all - it actually removes any timing dependency and brings the
same model to the visual UI and voice UI.

> 3) the splash could be called in any screen which means the screen's
> action context needs to be passed in...

Why?

pondlife
Received on 2009-06-17


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa