Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Pitch screen UI

Re: Pitch screen UI

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Fri, 19 Jun 2009 11:27:22 -0700

2009/6/19 David Johnston <david_at_pinkandaint.com>:
> So I'm doing some work on the pitch screen UI, mostly with regards to
> cleaner, more intuitive integration of the timestretching
> functionality, and I have a couple questions:
>
> 1. I'd like to set it up so that Rockbox remembers whether
> timestretching is on (not just available) and whether pitch is being
> incremented by percent or by semitone.  I think I've set up the two
> settings correctly, and I'm using the global_settings struct members
> as mode indicators in the UI code, but the states of those settings
> aren't getting saved between sessions.  I already did something
> similar with the morse code input screen (see my previous patch
> submission) and that worked fine.  The only difference there that I
> can tell is that I actually added an entry to the menu for toggling
> morse mode.  Does there have to be a menu item for a setting to be
> saved in the config file?  Or perhaps is there another struct that
> keeps track of whether a setting has changed?

to have them saved you need to add them to settings_list.c

>
> 2. Can anyone suggest a non-SWCODEC target to test on (via the ui
> simulator) to make sure all my changes work when timestretching isn't
> possible?
>
> -David
>
any of the archos targets
Received on 2009-06-19


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa