Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: kugel: r21460 - trunk/apps/metadata

Re: kugel: r21460 - trunk/apps/metadata

From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Mon, 22 Jun 2009 20:16:03 +0200

Hi,

Some nitpicking about a recent commit:

> FS#10364 - Optional debug output for vorbis.c by Jeffrey Goode.
>
> Gets rid of the (recently added) annyoing vorbis debug statements.
> Comment out "#define LOGF_ENABLE" in vorbis.c to restore them.

Any particular reason to adding a new define, LOGFQUEUE (a name that
makes sense in playback.c, where it is used for queue-related logging),
and only having it do something in simulator builds?

(I thought DEBUGF too was controlled by LOGF_ENABLE, by the way. :) )

   Magnus
Received on 2009-06-22


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa