Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)

Re: Center on loaded theme FS#10391 (+ set_file bugfix FS#10392)

From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Date: Mon, 29 Jun 2009 11:06:15 +0200

2009/6/28 Jonas Häggqvist <rasher_at_rasher.dk>:
> Still, the alternative is to select a random theme (the one sorted first).
> I believe a "best effort" (which will in fact often be 100% correct) is
> better than not trying at all.

Why not make this "best effort" to be the exact theme? My idea here is
to simply save the theme name if the user chooses one. Saving the
theme parts (font, etc) could even be dropped in that case. If the
user selects a different font, wps, etc later just drop the remembered
theme name and only remember the components -- then you'll hilight a
"random" theme when entering the theme selection, but as there isn't a
theme that matches the current state this is ok imo. If he didn't
change anything (which I guess will apply to most cases) then you can
hilight the correct theme.

 - Dominik
Received on 2009-06-29


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa