Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: r21912: Storage API : remove undeeded target-specific functions

r21912: Storage API : remove undeeded target-specific functions

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Fri, 17 Jul 2009 06:55:17 +0200

> r21912 <http://svn.rockbox.org/viewvc.cgi?view=rev;revision=21912>:
> Storage API : remove undeeded target-specific functions
>
> storage_sleep, storage_spin, storage_spindown are only defined if
> #defiend (HAVE_DISK_STORAGE), not for MMC/ATA/SD
> remove already unneeded nand_disk_is_active, nand_soft_reset

I don't understand that one.

Isn't the point of an API to forget about underlying differences so that
a developer doesn't need to care/know about this differences? This
commit introduces more (imo ugly) #ifdefs with destroying that point.

The functions are not target-specific, they're (if at all) storage type
specific, which is what the API wanted to hide.

Best regards.
Received on 2009-07-17


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa