Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: r21912: Storage API : remove undeeded target-specific functions

Re: r21912: Storage API : remove undeeded target-specific functions

From: Rob Purchase <rob.purchase_at_googlemail.com>
Date: Fri, 17 Jul 2009 16:28:55 +0100

On 17/07/2009 15:49, Rafaël Carré wrote:
>
> I think these functions do not belong to this API, and in fact this
> commit was not the correct way to go.
>
> Instead they should be renamed (according to my above explanation)
>
That is precisely what I was about to suggest - these functions only
have meaning for physical disks, so naming them storage_* does not make
sense.

Re: FS#9545, I don't see what else might be needed before commit. It's
confirmed working on at least two multi-driver targets, and there should
be little to no overheads on existing single-driver targets. But then,
I'm rather biased as the D2 SD driver depends on it going in ;-)

Rob.
Received on 2009-07-17


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa