|
Rockbox mail archiveSubject: Re: teru r22143: trunk/apps/pluginsRe: teru r22143: trunk/apps/plugins
From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Tue, 04 Aug 2009 15:10:13 +0200 Teruaki Kawashima schrieb: > >>> c) removing file causes disk access even though the file doesn't exist. >>> I agree that my change is not so good and better solution is needed. >>> same thing would be applied to other plugins like brickmania and >>> jewels. >> >> I think my solution wasn't bad afterall. Bubbles always accessed the >> disk at resuming, so that's not really an argument. But, you removed >> a (imo) very useful feature, to play bubbles without messing up the >> saved game. > IMO, bubbles is impoved to not access disk when resume game. I highly disagree if it means loosing the feature I mentioned. > I got one idea. how about check whether file is exists before try to > remove it when resume? > e.g. > > case 0: /* resume game */ > ... > if(rb->file_exists(SAVE_FILE)) > rb->remove(SAVE_FILE); > break; > > will this work? Probably only with dircache. I'm not sure. > >> >>> d) to match behavior with other plugins which use highscore. >> We don't need two quit items then, if both cause disk access, IMO. >> > but it doesn't always cause disk access as highscores are saved only > if they are changed. Ok, but still don't think we need two then. The "Quit" was meant to never have a disk access when I created the "Quit and Save" one. Received on 2009-08-04 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |