Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: teru r22143: trunk/apps/plugins

Re: teru r22143: trunk/apps/plugins

From: Teruaki Kawashima <kamekun_at_r6.dion.ne.jp>
Date: Tue, 04 Aug 2009 23:37:30 +0900

>>>> c) removing file causes disk access even though the file doesn't exist.
>>>> I agree that my change is not so good and better solution is needed.
>>>> same thing would be applied to other plugins like brickmania and
>>>> jewels.
>>>
>>> I think my solution wasn't bad afterall. Bubbles always accessed the
>>> disk at resuming, so that's not really an argument. But, you removed
>>> a (imo) very useful feature, to play bubbles without messing up the
>>> saved game.
>> IMO, bubbles is impoved to not access disk when resume game.
>
> I highly disagree if it means loosing the feature I mentioned.
>
>> I got one idea. how about check whether file is exists before try to
>> remove it when resume?
>> e.g.
>>
>> case 0: /* resume game */
>> ...
>> if(rb->file_exists(SAVE_FILE))
>> rb->remove(SAVE_FILE);
>> break;
>>
>> will this work?
>
> Probably only with dircache. I'm not sure.
I tested. it caused disk access without dircache and didn't with dircache.
maybe this is currently the best way if we can assume people who cares
about disk access would turn on dircache?

>>>> d) to match behavior with other plugins which use highscore.
>>> We don't need two quit items then, if both cause disk access, IMO.
>>>
>> but it doesn't always cause disk access as highscores are saved only
>> if they are changed.
> Ok, but still don't think we need two then. The "Quit" was meant to
> never have a disk access when I created the "Quit and Save" one.
>
well, feel free to revert my changes then.
Received on 2009-08-04


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa