Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: from r22350 on, load WPS files from theme files

Re: from r22350 on, load WPS files from theme files

From: Jonas Häggqvist <rasher_at_rasher.dk>
Date: Sun, 16 Aug 2009 21:10:57 +0200

Jonathan Gordon wrote:
> Hi all,
> I thing I forgot to mention in the commit message for r22350 is that
> you should load your .wps files from .cfg theme files (i.e not
> directly in the file browser), this is probably something you never do
> anyway, but I feel I need to let oyu know anyway...

I can assure you that enough people do to make this a problem.

> The new memory management stuff only resets the buffer when .cfg's are
> loaded, so if you manually load some image intensive .wps files
> directly it will eventually fail (silently) and you will get an empty
> now playing screen..

And you committed this with such an obvious bug? Incredible.

> If this happens for you though, just load a .cfg theme file and it
> will start working again.

So why don't you just do whatever magic happens when any .cfg file is
loaded when a .wps file is loaded also?

I suggest either fixing this ASAP, or reverting until the patch is more
mature.

-- 
Jonas Häggqvist
rasher(at)rasher(dot)dk
Received on 2009-08-16

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa