Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: blue_dude: r22690 - in trunk/apps: . lang

Re: blue_dude: r22690 - in trunk/apps: . lang

From: Jonas Häggqvist <rasher_at_rasher.dk>
Date: Sun, 13 Sep 2009 10:50:39 +0200

mailer_at_svn.rockbox.org wrote:
> Date: 2009-09-13 06:16:25 +0200 (Sun, 13 Sep 2009)
> New Revision: 22690
>
> Log Message:
> Laying the groundwork for future features
>
> Modified:
> trunk/apps/lang/english.lang
> trunk/apps/lang/francais.lang
> trunk/apps/lang/italiano.lang
> trunk/apps/lang/polski.lang
> trunk/apps/lang/svenska.lang
> trunk/apps/lang/tagalog.lang
> trunk/apps/settings_list.c
>
> Modified: trunk/apps/lang/english.lang
> ===================================================================
> --- trunk/apps/lang/english.lang 2009-09-12 22:31:29 UTC (rev 22689)
> +++ trunk/apps/lang/english.lang 2009-09-13 04:16:25 UTC (rev 22690)
> @@ -12702,7 +12702,7 @@
> </voice>
> </phrase>
> <phrase>
> - id: LANG_LIMITER
> + id: LANG_COMPRESSOR
> desc: in sound settings
> user: core
> <source>

I don't believe modifying language files like this is good. The correct
way is to first deprecate LANG_LIMITER, then add LANG_COMPRESSOR at the
end of the file. This way old language files and voice files will still work.

Or am I just confused?

-- 
Jonas Häggqvist
rasher(at)rasher(dot)dk
Received on 2009-09-13

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa