Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: FS#10187:Theme Deleter - Parses CFG files and removes their files

Re: FS#10187:Theme Deleter - Parses CFG files and removes their files

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Thu, 08 Oct 2009 20:08:45 +0200

On 08.10.2009 14:50, Teruaki Kawashima wrote:
>
>> I'm also unsure why it implements a printf(), are existing tools not
>> applicable?
>>
> I wanted to show entire path of file names. From my experience, path
> tends to not contain spaces and splashf() doesn't handle such strings well.
> But since the printf() isn't still good especially for smaller LCDs, I
> can change it to use splashf().

There are more ways to print a string, like various puts functions. It
doesn't need to be a splash. You can even add scrolling for long
filenames on small screens.

>> What's the point of rockbox-fonts.config, what is it used for? Rockbox
>> isn't limited to the fonts pre-installed. Anyone can build their own
>> font and use them in themes.
>>
> For the purpose of rockbox-fonts.config, see the comment at
> http://www.rockbox.org/tracker/task/10187#comment31796 and next one.
> In such a case, users would change setting to not remove fonts at all.
>

I see, I don't like it though. The mechanism seems rather wobby and
wasted special casing adding much complexity. What's the gain really? If
a theme from the theme site doesn't work, the user can just re-download
the package.

Additionally, I don't see why icons and fonts are handled differently,
asking for deletion of fonts also is the better way IMO.

> It removes the .cfg file only if the file is in the
> /.rockbox/themes directory though.
>
>

Why?

Best regards.
Received on 2009-10-08


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa