Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: FS#10187:Theme Deleter - Parses CFG files and removes their files

Re: FS#10187:Theme Deleter - Parses CFG files and removes their files

From: Teruaki Kawashima <kamekun_at_r6.dion.ne.jp>
Date: Sat, 10 Oct 2009 22:11:07 +0900

> On 09.10.2009 16:18, Teruaki Kawashima wrote:
>>>> I wanted to show entire path of file names. From my experience, path
>>>> tends to not contain spaces and splashf() doesn't handle such strings
>>>>
>> well.
>>
>>>> But since the printf() isn't still good especially for smaller LCDs, I
>>>> can change it to use splashf().
>>>>
>>> There are more ways to print a string, like various puts functions. It
>>> doesn't need to be a splash. You can even add scrolling for long
>>> filenames on small screens.
>>>
>>>
>> puts_scroll isn't so different from splash here, imo.
>>
>>
>>>>> What's the point of rockbox-fonts.config, what is it used for? Rockbox
>>>>> isn't limited to the fonts pre-installed. Anyone can build their own
>>>>> font and use them in themes.
>>>>>
>>>>>
>>>> For the purpose of rockbox-fonts.config, see the comment at
>>>> http://www.rockbox.org/tracker/task/10187#comment31796 and next one.
>>>> In such a case, users would change setting to not remove fonts at all.
>>>>
>>>>
>>> I see, I don't like it though. The mechanism seems rather wobby and
>>> wasted special casing adding much complexity. What's the gain really? If
>>> a theme from the theme site doesn't work, the user can just re-download
>>> the package.
>>>
>>>
>> Isn't it a gain to save user reinstalling fonts?
>>
>>
>
> But the user explicitely decided to delete the fonts. Why are we trying
> to be more intelligent than the user?
> Reinstalling fonts isn't a problem IMO, actually the fonts should be
> downloaded periodically in case something changes in SVN.
>
I don't see your point. If the user wants to delete them, nothing
prevents him to do so.

>>> Additionally, I don't see why icons and fonts are handled differently,
>>> asking for deletion of fonts also is the better way IMO.
>>>
>>>
>> It's not more than that I didn't think so when I wrote it. I'll change
>> it to "Ask".
>>
>>
>>>> It removes the .cfg file only if the file is in the
>>>> /.rockbox/themes directory though.
>>>>
>>>>
>>> Why?
>>>
>>>
>> the .cfg files in the /.rockbox/themes/ would be theme file but the
>> files in other directories may not be theme file. e.g
>> /.rockbox/config.cfg and /.rockbox/fixed.cfg.
>>
>>
>
> The user explicitly selected that very .cfg. Again, why are we trying to
> be more intelligent than the user? I see now point in limiting the
> deletion to /.rockbox/themes.
>
It's a simple protection against accidental removal of files.
It's easy to delete the single .cfg file. Plus, the user can choose not
to delete it.
Received on 2009-10-10


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa