Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: kugel: r23209 - in trunk/apps: . gui gui/skin_engine recorder

Re: kugel: r23209 - in trunk/apps: . gui gui/skin_engine recorder

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Sat, 17 Oct 2009 12:39:02 +0200

Magnus Holmgren schrieb:
> mailer_at_svn.rockbox.org wrote:
>
>> Date: 2009-10-16 21:14:41 +0200 (Fri, 16 Oct 2009)
>> New Revision: 23209
>>
>> Log Message:
>> Rework albumart buffering internally to allow for mutliple albumart
>> sizes.
>
> <...>
>
>> --- trunk/apps/plugin.h 2009-10-16 19:14:37 UTC (rev 23208)
>> +++ trunk/apps/plugin.h 2009-10-16 19:14:41 UTC (rev 23209)
>> @@ -789,7 +789,8 @@
>>
>> #if (CONFIG_CODEC == SWCODEC)
>> /* buffering API */
>> - int (*bufopen)(const char *file, size_t offset, enum data_type
>> type);
>> + int (*bufopen)(const char *file, size_t offset, enum data_type
>> type,
>> + void *user_data);
>
> Doesn't that break backwards compatibility? I couldn't find any plugin
> using the buffering API when searching the code though...
>
> Magnus

Right, I forgot to bump; but yea no plugin calls it so I didn't think
about further.
Received on 2009-10-17


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa