Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: theseven: r23327 - trunk/firmware/target/arm/s5l8700

Re: theseven: r23327 - trunk/firmware/target/arm/s5l8700

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Sat, 24 Oct 2009 12:20:47 +0200

Rafaël Carré schrieb:
>> -static void* dma_callback(void) ICODE_ATTR;
>> +static void* dma_callback(void) ICODE_ATTR __attribute__((unused));
>>
>
> If it's hidden because the function is never used, i would use #if 0
> perhaps with a comment
>
>

It is used in inline assembly. But a comment would have been nice indeed.

Best regards.
Received on 2009-10-24


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa