Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: the UI viewport logic.. someone please help my understanding?

Re: the UI viewport logic.. someone please help my understanding?

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 28 Oct 2009 11:23:13 -0700

2009/10/28 Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>:
> Jonathan Gordon schrieb:
>>
>> OK try this,,,
>> 1) sbs are intended to be completly seperate to themes
>> 2) a wps is also sort of independant from themes, BUT is made to work with
>> a sbs
>> 3) THE *only* time that the Vi is taken into account is in the wps
>> (which can draw anywhere it likes anyway?
>>
>> So, get rid of Vi, everything it does now can be done using the
>> setting... *and* we can make it stupidly simple so you cant accidently
>> load a sbs without a viewport setup. after the sbs is loaded it would
>> clear the whole screen, draw once, and stick a crosshair on the screen
>> so the user can draw the viewport where the UI area should go.
>>
>
>
> That can't work. sbs is independent of themes. But the UI viewport is not
> part of the sbs at all. And the WPS cannot draw where it likes, since the
> default viewport is always active (and maximized).
>
> Using the UI vp for skins is mixing parts which simply do not belong
> together.
>
>
> /me wonders why JdGordon sees problems when there's none.
>
> Best regards.
>

You said yourself that the ui vp and the sbs are totally seperate...
then how on earth can there be any reason for the Vi tag? and of
course the wps can draw whereever it wants...

have a look at the attached imaged... on the top is the current code,
the bottom is how I think it should work...
On the left is in the lists.. the red area is where the sbs draws, the
white area is the %Vi viewport, the green is the setting viewport
(where the list actually gets drawn). On the right is in the WPS with
the sbs enabled, the WPS can happily draw anywhere it wants (as shown
by the blue star which overlaps the red slightly... there may be
redraw issues, but its perfectly legal.

The bottom bit it how I think it should work (with no %Vi), red is
where the sbs draws, white is dead space that nothing apparently draws
into, green is the viewport setting. As you can see the only
difference is in the WPS where the default viewport is the green, but
thats fine because we can still draw anywhere else in the screen that
we want!

Now can you see that Vi is redundant?

Untitled.png
Received on 2009-10-28

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa