Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: the UI viewport logic.. someone please help my understanding?

Re: the UI viewport logic.. someone please help my understanding?

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 28 Oct 2009 11:56:16 -0700

2009/10/28 Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>:
> Because the %Vi is a property of a sbs, and the UI vp is something totally
> unrelated.

it *does* nothing to the sbs though, so how can it be a property of
it? other than thats where it is specified? it controls nothing in
that screen

> I want those separate because there's a need for separation. A number of
> screens ignore the UI vp and want everything (but still want statusbar). For
> example the USB screen, or (hopefully soon) dozens of plugins, and of course
> for the default viewport of the WPS (which is simply not supposed to be
> bound within the UI vp!).
>

and they would be negatively affected how if the place they get their
defaults from changes?

>
> You simply want to remove flexibility and freedom to allow other parts to be
> independent of the lists viewport. And of course mix create
> interdependencies between skins and themes.

I dont change anything of the sort.. what I do get rid of is
inconsistancies in the current code.... quick without thinking or
checking anything what viewport can screen X expect if a sbs is
loaded? your answer is "well it depends *what* screen X is... it
shouldnt!

>
> And for what? The entire %Vi handling is less than 10 lines of code.
>
Do you have a guilty conscience about the code or something? I've
never brought up its code impact...

>> Now can you see that Vi is redundant?
>>
>
>
> No.
>
>
arg
Received on 2009-10-28


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa