Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: r23491 - jdgordon - apps/gui/skin_engine/

r23491 - jdgordon - apps/gui/skin_engine/

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Tue, 03 Nov 2009 15:06:29 +0100

> commit 0f6783e3b584b2befd937fe84f17a3f64aced3ba
> Author: jdgordon <jdgordon_at_a1c6a512-1295-4272-9138-f99709370657>
> Date: Tue Nov 3 07:58:10 2009 +0000
>
> Initial recording screen skin support (usable in .sbs skins only
> for now)
> new skin tokens:
> %Rp - does the target have recording?
> %Rf - samplerate
> %Re - encoder
> %Rb - bitrate
> %Rm - mono/stereo
>
> Please put all bugs from these (which very probably dont work
> 100%) into FS#10755. And someone who knows how the recoding
> capabilities work
> CustomWPS on the wiki for more details
>
>
> git-svn-id: svn://svn.rockbox.org/rockbox/trunk_at_23491
> a1c6a512-1295-4272-9138-f99709370657
> ---
> apps/gui/skin_engine/skin_parser.c | 17 +++-
> apps/gui/skin_engine/skin_tokens.c | 196
> ++++++++++++++++++++++++++++++++++++
> apps/gui/skin_engine/skin_tokens.h | 7 ++
> 3 files changed, 219 insertions(+), 1 deletions(-)

There's at least 1, if not more, new tags that can properly be expressed
with an equivalent %St|<setting>| expression.

Since we have %St, we try to avoid tags that simply wrap a
global_settings variable where possible, and I think we just didn't
remove the (very few) existing tags of that sort to keep old themes
compatible.

I don't really like wasting code on tags that have an existing
equivalent already. Having multiple ways of expressing the same thing
can be confusing for WPS/SBS authors too. Hence I'm not a fan of parts
of the commit.

Do/Can we have an official consensus about those tags?

PS: A very short discussion started (which wasn't very fruitful due to
lazy answers) here in IRC: http://www.rockbox.org/irc/log-20091103#09:01:20

Best regards.
Received on 2009-11-03


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa