Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: r23491 - jdgordon - apps/gui/skin_engine/

Re: r23491 - jdgordon - apps/gui/skin_engine/

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Tue, 03 Nov 2009 20:50:18 +0100

On 03.11.2009 19:15, Jonathan Gordon wrote:
>
> What is the actual harm in having both? it can obviously be argued
> either way makes the skin more readable, and there is absolutly no
> negative impact on adding the extra token (when we run out of 2 letter
> combos we will be up the creek anyway), and that *entire* commit added
> under 1000bytes on the worst target (and I highly doubt it was because
> of the one setting which gets a duplicate tag)
>

This is what I meant with that you change your coding style every other
day. (Some of) The new tags are completely redundant. A few days ago you
discussed hard to kill the "redundant" (it really isn't) %Vi tag.
Received on 2009-11-03


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa