Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: kugel: r23526 - trunk/apps/gui

Re: kugel: r23526 - trunk/apps/gui

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 4 Nov 2009 18:36:04 -0800

I think this is a bad "fix" for the non bg (which we agreed it was it
irc)... I tihnk the better fix is the go back to calling
set_fullscreen() at the start of set_defaults() so the font is always
user font, and the colours are always from the settings... I cant
tihnk of any reason why a skin shuold set the font or colours for the
lists (and getting them from the "ui viewport" setting doesnt make
sense either, because this change doesnt work if that isnt set.)

Also, the changed comment is now incorrect (or still badly worded..
yay for the english language!)

2009/11/4 Jonas Häggqvist <rasher_at_rasher.dk>:
>
> --
> Jonas Häggqvist
> rasher(at)rasher(dot)dk
>
> Date: 2009-11-04 23:55:02 +0100 (Wed, 04 Nov 2009)
> New Revision: 23526
>
> Log Message:
> Get font and colors from UI viewport before intersecting, instead of leaving
> them empty.
>
> Modified:
>   trunk/apps/gui/viewport.c
>
> Modified: trunk/apps/gui/viewport.c
> ===================================================================
> --- trunk/apps/gui/viewport.c   2009-11-04 22:24:47 UTC (rev 23525)
> +++ trunk/apps/gui/viewport.c   2009-11-04 22:55:02 UTC (rev 23526)
> @@ -384,7 +384,10 @@
>             a->x + a->width  > b->x              &&
>             a->y             < b->y + b->height  &&
>             a->y + a->height > b->y)
> -        {   /* interesect so that the ui viewport is cropped so that it
> +        {
> +            /* copy from ui vp first (for other field),fix coordinates
> after */
> +            *vp = *user_setting;
> +            /* interesect so that the ui viewport is cropped so that it
>              * is completely within the info vp */
>             vp->x = MAX(a->x, b->x);
>             vp->y = MAX(a->y, b->y);
>
> _______________________________________________
> rockbox-cvs mailing list
> rockbox-cvs_at_cool.haxx.se
> http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
>
>
>
Received on 2009-11-05


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa