Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Bug or intentional?

Re: Bug or intentional?

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Mon, 28 Dec 2009 13:17:52 +0100

Am 28.12.2009 11:47, schrieb Bertrik Sikken:
> On 27-12-2009 4:25, Paul Louden wrote:
>
>> Apparently within the WPS context menu some submenus (for example, sound
>> settings) can be entered and exited without leaving to the WPS.
>> Meanwhile others (like Playlist) cannot. Attempting to leave them by
>> pressing "left" will take you to the WPS again rather than back to the
>> root menu. JdGordon says this was intentional at some point.
>>
> I think this is indeed intentional.
>
> There is even a special macro to mark a menu as an "onplay" menu.
> I actually tried to make this more consistent (it was easily possible
> to make it completely consistent) in FS#9037
> http://www.rockbox.org/tracker/task/9037
>
>

Well, your patch is committed, and it is still very inconsistent.

I don't think it's intentional actually. IIRC the "classic" items always
left to the WPS. At some point some items where replaced with the ones
that are used in the normal menus too (so the WPS context menus doesn't
duplicate the code), but these don't leave to the WPS directly (the IMO
preferred behavior).

>> Can anyone explain the rational behind why we should have menus that
>> work normally going "right" but inexplicably don't when going "left" or
>> is this something we can fix going forward rather than preserving it as
>> a bad behaviour?
>>
> I don't know the rationale and wouldn't mind removing this special
> behaviour.
>
> Kind regards,
> Bertrik
>

Same here. I would rather to have all menus act so that pressing left
means going back 1 level, not completely to the WPS.
Received on 2009-12-28


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa