Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: uchida: r25233 - trunk/apps/plugins

Re: uchida: r25233 - trunk/apps/plugins

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Wed, 17 Mar 2010 19:10:47 +0100

Am 17.03.2010 15:22, schrieb Frank Gevaerts:
> On Wed, Mar 17, 2010 at 12:17:56PM +0100, mailer_at_svn.rockbox.org wrote:
>
>> Log Message:
>> text viewer plugin applies patches FS#8445, FS#9546, FS#9853, FS#9855, FS#9892, FS#9893, FS#9898, FS#9902, and FS#9990.
>>
> I think commit messages should have a description of the commit, not
> just a reference to the tracker.
>
> Frank
>
>

Also, if the patches are already separate, they should also be committed
separately IMO (with a description for each as gevaerts mentioned).
Received on 2010-03-17


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa