|
Rockbox mail archiveSubject: Re: Bookmark modRe: Bookmark mod
From: Jeff Goode <jeffg7_at_gmail.com>
Date: Fri, 09 Apr 2010 16:22:33 -0400 On 4/9/2010 14:26, Thomas Martitz wrote: > Am 09.04.2010 20:05, schrieb Dominik Riebeling: >> setting some value and playing a podcast, then (maybe because the >> podcast has ended) resuming a different one from a bookmark that >> doesn't contain any speed information. IMO it would be confusing if >> pitch / speed were reset to 100%. Why set a value that isn't existing >> in the bookmark? That's similar to the settings: all values that >> aren't in a cfg file are not changed instead of resetting them to some >> default. I don't think doing it differently for the same situation on >> bookmarks is a good idea. > > Pitch is different, as it's (AFAIK) intentionally not a setting so it > resets to 100% on reboot, since ages. It's simply non-persistent. So > resetting to 100% if the bookmark info doesn't contain pitch > information is what we probably want. > > Isn't this a question about backwards-compability anyway? I assumed > newly created bookmarks get a specific pitch value. > It is only an issue of backward compatibility. New bookmarks have pitch and speed tokens so there's no guesswork involved. Received on 2010-04-09 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |