Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: WPS playlist viewer exposes a bug in either plaback/buffering or playlist. I'm stumped!

Re: WPS playlist viewer exposes a bug in either plaback/buffering or playlist. I'm stumped!

From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Sat, 17 Apr 2010 13:22:39 +0200

On 2010-04-17 13:16, Magnus Holmgren wrote:

> * Looks like "buf" (in draw_playlist_viewer_list) can overflow. Consider
> what happens if "buf_used" goes larger than "sizeof(buf)"... Suggestion:
> use strlcat instead. Protects against overflow and simplifies the code.
> Don't know if that's what causing the problems though.

Sorry, missed the buf_used check in the "while" statement, and the
"continue" statement... So it seems overflow safe. strlcat would still
be simpler though. :)

-- 
   Magnus
Received on 2010-04-17

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa