Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: svn properties

Re: svn properties

From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Date: Mon, 14 Jun 2010 20:21:21 +0200

On Mon, Jun 14, 2010 at 7:40 PM, Rafaël Carré <rafael.carre_at_gmail.com> wrote:
> I suppose it's because like me, you don't like unnecessary changes.
> "Don't fix what ain't broke."
>
> But here, it's broke.

The problem with setting properties is clearly a problem of git-svn,
thus it's broken on the git-svn end, not on the svn end. It's even
mentioned in the BUGS section of the git-svn man page (at least on my
machine): We ignore all SVN properties except svn:executable.

If it's broken at the non-svn end then it isn't the proper solution to
change the svn end.

I wouldn't object to _sensible_ changes to decrease the problems, but
just removing svn:eol-style because git-svn ignores it isn't a proper
solution IMO. Also, with svn:eol-style set svn gains the possibility
to warn / error out if trying to commit mixed-style files. Which can
happen, and even did happen to me. Some editors (one comes into my
mind: UltraEdit on Windows) even always wants to convert each file to
DOS line endings (you can disable this in UltraEdit but it's pretty
hidden in the settings). And if you don't follow that you might get
files with mixed line ending. So there is even a use for svn:eol-style
beyond converting between DOS and Unix line endings on the appropriate
environments.

 - Dominik
Received on 2010-06-14


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa