Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Destructors in Theme Editor: virtual or non virtual?

Re: Destructors in Theme Editor: virtual or non virtual?

From: Al Le <Al.Le_at_gmx.de>
Date: Thu, 17 Jun 2010 17:02:26 +0200

> Out of curiosity I looked at the code of the Theme Editor which is written
> in C++. And saw, e.g. in the class SkinViewer, that the destructor is
> declared as a non-virtual function. But shouldn't (almost always) destructors
> be declared as virtual functions so that the framework (Qt in this case) can
> correctly destroy custom objects?

The above statement is correct. But it seems also correct that if the destructor is declared as virtual in the base class then it's automatically virtual in all (directly or indirectly) derived classes. So the code in the Theme Editor is OK.

-- 
GMX DSL: Internet-, Telefon- und Handy-Flat ab 19,99 EUR/mtl.  
Bis zu 150 EUR Startguthaben inklusive! http://portal.gmx.net/de/go/dsl
Received on 2010-06-17

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa