Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: svn properties

Re: svn properties

From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Date: Thu, 17 Jun 2010 19:56:28 +0200

On Thu, Jun 17, 2010 at 7:06 PM, Frank Gevaerts <frank_at_gevaerts.be> wrote:
>> What's up with this, does anyone still object?
>
> As I've stated several times now, yes.

I also don't like the proposed solution. IMO it's not a proper
solution, and we shouldn't add solutions that don't really fix the
original problem just because someone doesn't like the current state.
Instead we should go for the proper solution, even if it takes a
couple of days longer -- this isn't critical in any way at least.

For the record, I've just tried svn's autoprops feature together with
git-svn. It works fine in my environment (svn 1.6.9, git 1.6.6.1, I'll
try to check with an older installation later). A more appropriate
solution would be IMO:

- set all source files to svn:eol-style=LF except files that need CRLF.
- add a proposed ~/.subversion/config file to UsingSVN and especially
tell to use autoprops on the GitVersionControl wiki page. As far as I
can see this should do it:

 [miscellany]
 enable-auto-props = yes

[auto-props]
*.c = svn:eol-style=LF
*.s = svn:eol-style=LF
*.S = svn:eol-style=LF
*.cpp = svn:eol-style=LF
*.h = svn:eol-style=LF
*.ui = svn:eol-style=LF
*.sh = svn:eol-style=LF
*.pl = svn:eol-style=LF
*.pm = svn:eol-style=LF
*.py = svn:eol-style=LF
*.txt = svn:eol-style=LF
*.cfg = svn:eol-style=LF
*.wps = svn:eol-style=LF
*.sbs = svn:eol-style=LF
*.vbs = svn:eol-style=LF # should this be CRLF?)
*.png = svn:mime-type=image/png
*.jpg = svn:mime-type=image/jpeg
*.bmp = svn:mime-type=image/bmp
*.svg = svn:mime-type=image/svg
Makefile = svn:eol-style=LF

This will leave out a few file types that are used rarely, and for
that case the committer should be able to take care of svn:eol-style
himself. Please point out any file types I missed that should be in
this list.

Regardless of svn:eol-style and autoprops I'd vote for removing
svn:keywords completely.

 - Dominik
Received on 2010-06-17


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa