Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Re: Re: uchida: r27333 - trunk/apps

Re: Re: Re: uchida: r27333 - trunk/apps

From: Yoshihisa Uchida <y_uchida-lj_at_infoseek.jp>
Date: Thu, 08 Jul 2010 21:16:59 +0900

Jonathan,

> -----Original message-----
> Sender: "Jonathan Gordon" <jdgordy_at_gmail.com>
> Receiver: "Rockbox development" <rockbox-dev_at_cool.haxx.se>
> Date: 10/07/07 21:58
> Subject: Re: Re: uchida: r27333 - trunk/apps
>
> 2010/7/7 Yoshihisa Uchida <y_uchida-lj_at_infoseek.jp>:
> > Frank,
> >
> Anyway, What is r27334 trying to achieve? Either you should respect
> the theme and leave it to the viewport manager to update the screen
> outside of the UI area, or ignore the theme completly and manually
> draw the inbuilt statusbar with calls to gui_statusbar_draw which will
> draw the bar at the top of the given viewport.
>
> Jonathan
>

I think so. However, I chose an easy correction method because I had thought this correction to be a little difficult.

I think that these functions (i.e., functions that I added) should be delete from plugin.[ch] in the future.
Until this correction is done, please put them in the structure.
 
Sincerely yours,
Yoshihisa Uchida
Received on 2010-07-08


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa