Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: gain settings in recording screen

Re: gain settings in recording screen

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Tue, 24 Aug 2010 17:29:19 +0200

  On 24.08.2010 16:59, Nils Wallménius wrote:
> On Tue, Aug 24, 2010 at 8:19 AM, Marcin Bukat<marcin.bukat_at_gmail.com> wrote:
>> Hello rockboxers!
>> I would like to get some feedback for FS#11534 as I got no single comment on FS.
>> Currently the step when changing gain/vol settings in recscreen is
>> always 0.1dB. Many (most?) codecs can't handle such fine grained gain
>> changes.
>> For example 1.5dB steps are common among wolfson codecs. This patch
>> changes the behavior such that step defined in audiohw_settings[] is
>> taken when changing gain/vol in recscreen. In my opinion there is no
>> reason to fool users that we support something that hardware can't
>> handle.
>>
>> Another thing is that currently every driver claims 0.1dB steps for
>> gain in audiohw_settings[] which should be IMO fixed.
>>
>> looking forward to hear what do You think
>> Marcin Bukat (wodz)
>>
> I agree, telling the user the truth is a Good Thing (TM).
>
> Nils

Doesn't that make config files (eq presets also?) incompatible?

I'm not sure if exposing the hardware differences is needed. Stuff like
that is even hidden in many library APIs, let alone the user visible parts.

Best regards.
Received on 2010-08-24


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa