Rockbox mail archive
Subject: Re: jdgordon: r28078 - trunk/apps/radio
Re: jdgordon: r28078 - trunk/apps/radio
On 9/14/2010 3:47 PM, Rafaël Carré wrote:
> This commit log isn't really much less descriptive than, say, "fix red", which
> seems to be an acceptable commit log though.
> So while I prefer long and descriptive log messages, this particular log doesn't
> really bother me.
So was this a "fix red" commit then? Was it related to a screwup in a
previous commit, or entirely unrelated.
"Fix red" pretty explicitly tells someone that this is a followup commit
to a slightly earlier one that caused build errors. "Grumble" on the
other hand leaves me no clue if it was related to something else you did
earlier, or not.
Received on 2010-09-14
Page was last modified "Jan 10 2012" The Rockbox Crew