Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r28078 - trunk/apps/radio

Re: jdgordon: r28078 - trunk/apps/radio

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Tue, 14 Sep 2010 23:18:49 +0200

  On 14.09.2010 22:55, Paul Louden wrote:
> On 9/14/2010 3:47 PM, Rafaël Carré wrote:
>> This commit log isn't really much less descriptive than, say, "fix
>> red", which
>> seems to be an acceptable commit log though.
>>
>> So while I prefer long and descriptive log messages, this particular
>> log doesn't
>> really bother me.
>>
> So was this a "fix red" commit then? Was it related to a screwup in a
> previous commit, or entirely unrelated.
>
> "Fix red" pretty explicitly tells someone that this is a followup
> commit to a slightly earlier one that caused build errors. "Grumble"
> on the other hand leaves me no clue if it was related to something
> else you did earlier, or not.

I agree, fix red (even if not terribly good either) is a lot better than
this.

Best regards.
Received on 2010-09-14


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa