Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r28078 - trunk/apps/radio

Re: jdgordon: r28078 - trunk/apps/radio

From: Paul Louden <paulthenerd_at_gmail.com>
Date: Tue, 14 Sep 2010 23:28:39 -0500

  On 9/14/2010 11:23 PM, Jonathan Gordon wrote:
>
> If anything that argument is one *for* the short "fix red", "bugger"
> commit messages NOT AGAINST THEM.
> When skimming the commit logs you know immediately to go straight past
> any of those messages.
>
> Besides, if you are searching for possible breaks and using the commit
> message as your first filter is incredibly dangerous.
Who said anything about "searching for breaks?"

The whole idea of the commit log is to give a brief summary of what was
done. Not necessarily looking for breaks, it can also make is easy to
know which ones are inconsequential. But "Bugger" doesn't say "this is
inconsequential." There's no context in that description to tell if it's
meant to imply that it was inconsequential or if it was just someone
being lazy and not feeling like writing a commit message.
Received on 2010-09-15


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa