Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r28078 - trunk/apps/radio

Re: jdgordon: r28078 - trunk/apps/radio

From: Karl Kurbjun <kkurbjun_at_gmail.com>
Date: Tue, 14 Sep 2010 23:34:07 -0600

On 09/14/2010 10:51 PM, Paul Louden wrote:
> On 9/14/2010 11:46 PM, Jonathan Gordon wrote:
>>
>> I think it is incredibly rude to suggest that anyone would do an empty
>> message on an important commit
>
> That doesn't meant it can't happen.
>
> What exactly is the objection to "try to give at least a brief summary
> of what you fixed/changed in commit messages?" Why is this idea
> disliked so much by you and Karl, exactly?
>
> Even "fixed red" covers that. Meanwhile why even write something if
> it's just "bugger?"

My comment on the message was in line with Rafael's so I am not sure why
my name is being drug around with something I never said.

I think the intent of the message was clear. This is not a 100+ line
commit. It is not even a 10 or 5 line commit.

It is one line.

To be precise it is one character.

My 'message' is that this, in my opinion, is an unneeded discussion for
something inconsequential.

It appears to be singling one person out which is why I perceive it as
impolite to bring up in the list immediately without discussing it with
the individual.

-Karl
Received on 2010-09-15


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa