Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r28078 - trunk/apps/radio

Re: jdgordon: r28078 - trunk/apps/radio

From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Date: Wed, 15 Sep 2010 08:17:28 +0200

On Wed, Sep 15, 2010 at 7:34 AM, Karl Kurbjun <kkurbjun_at_gmail.com> wrote:
> I think the intent of the message was clear.  This is not a 100+ line
> commit.  It is not even a 10 or 5 line commit.

The amount of lines (or even characters) changed with a commit does
not necessarily correlate with the description that is appropriate. A
100+ lines commit could justify a single line commit message only (I
just need to remember the days when we had those "code police" commits
which was completely sufficient. Of course those could have gotten
comments like "fix indentation, remove tabs, and kill trailing spaces"
or whatever but in such a case a 100+ lines commit wouldn't need more
explanation). In contrast I can very well imagine a single line change
that requires quite a bit of explanation since it fundamentally
changes things (just think of some macro that is used all over the
place).

 - Dominik
Received on 2010-09-15


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa