Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: A commit message template?

Re: A commit message template?

From: Mohamed Tarek <mtarek16_at_gmail.com>
Date: Fri, 17 Sep 2010 02:21:50 +0300

On Thu, Sep 16, 2010 at 9:46 PM, Amaury Pouly <amaury.pouly_at_gmail.com>wrote:

>
> Going half-way is a bad idea, there will be no benefit if only part of the
> developpers follow the template.
>
>
I wanted to mention this point in my previous reply. If I remember
correctly,
there was a discussion before about writing good commit messages. Hadn't
we tolerated exceptions the current "commit template" discussion might
have possibly never taken place. At least it wouldn't have been
triggered by a commit message.

I for one would be happier with better structured commit messages, i.e
I'm not against a commit message template ( I just wanted to state that
I agreed with Jonathan that it may cause a bit of a slow down ).

But then again, how would we deal with exceptions ? exceptions will
always occur, either deliberately or by mistake. For example, I was once
trying a new svn front-end, and committed with no message by mistake.
Back then I wished we had had the ability to edit commit messages. And
I sure hope that being flamed at wouldn't be the solution for such a
scenario. :)

To conclude this, while it would be nicer to have better commit
messages, I don't really see the message itself as much of a problem as
a message that needs correction. So whatever the consensus is
regarding the commit message structure, we'd still need to have the
ability to edit it should a problem arise.

-- 
MT
Received on 2010-09-17

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa