Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: kugel: r28423 - trunk/apps

Re: kugel: r28423 - trunk/apps

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Tue, 2 Nov 2010 00:19:46 +1100

As per the other thread my view is this should be reverted (for both
targets), no one is objecting to this when the target is ready (as
defined by not being able to get stuck in any screen except panic when
in stylus mode, and giving visual feedback that grid mode has been
enabled temporarily).

On 1 November 2010 03:22, <mailer_at_svn.rockbox.org> wrote:
> Date: 2010-10-31 17:22:32 +0100 (Sun, 31 Oct 2010)
> New Revision: 28423
>
> Log Message:
> Default to absolute point mode on RaaA and Onda targets. Cowon D2 and MRobe 500 stick to grid mode for now.
>
> Modified:
>   trunk/apps/settings_list.c
>
> Modified: trunk/apps/settings_list.c
> ===================================================================
> --- trunk/apps/settings_list.c  2010-10-31 15:40:43 UTC (rev 28422)
> +++ trunk/apps/settings_list.c  2010-10-31 16:22:32 UTC (rev 28423)
> @@ -464,6 +464,18 @@
>  }
>  #endif
>  #ifdef HAVE_TOUCHSCREEN
> +
> +#if defined(APPLICATION)
> + || defined(ONDA_VX747)
> + || defined(ONDA_VX767)
> + || defined(ONDA_VX747P)
> + || defined(ONDA_VX777)
> +
> +#define DEFAULT_TOUCHSCREEN_MODE TOUCHSCREEN_POINT
> +#else
> +#define DEFAULT_TOUCHSCREEN_MODE TOUCHSCREEN_BUTTON
> +#endif
> +
>  static void tsc_load_from_cfg(void* setting, char*value)
>  {
>     struct touchscreen_parameter *var = (struct touchscreen_parameter*) setting;
> @@ -1711,7 +1723,7 @@
>                   audiohw_enable_speaker),
>  #endif
>  #ifdef HAVE_TOUCHSCREEN
> -    CHOICE_SETTING(0, touch_mode, LANG_TOUCHSCREEN_MODE, TOUCHSCREEN_BUTTON,
> +    CHOICE_SETTING(0, touch_mode, LANG_TOUCHSCREEN_MODE, DEFAULT_TOUCHSCREEN_MODE,
>                    "touchscreen mode", "point,grid", NULL, 2,
>                    ID2P(LANG_TOUCHSCREEN_POINT), ID2P(LANG_TOUCHSCREEN_GRID)),
>     CUSTOM_SETTING(0, ts_calibration_data, -1,
>
> _______________________________________________
> rockbox-cvs mailing list
> rockbox-cvs_at_cool.haxx.se
> http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
>
Received on 2010-11-01


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa