Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: re r28480

Re: re r28480

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Fri, 5 Nov 2010 09:21:35 +1100

On 5 November 2010 02:30, Al Le <Al.Le_at_gmx.de> wrote:
> Hello.
>
> I have a couple of questions / suggestions about the patch.
>
> 1. Shouldn't the vars 'first' and 'last' be declared static? And renamed to something more specific, e.g. 'alloced_list_head' and '..._tail'?
>
> 2. Shouldn't the result of the call to malloc be casted to the desired pointer type?
>
> 3. I think, the list tail is not properly updated in the malloc function for the 'USE_HOST_MALLOC' branch

Thanks! haha looked completely fine while I was replying before, press
send, leave the desk for 2 min and it clicks :p
Received on 2010-11-04


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa