Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: FS#11696 - scrollwheel not responding on e200 v1

Re: FS#11696 - scrollwheel not responding on e200 v1

From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Fri, 5 Nov 2010 09:36:53 +0100

On Fri, Nov 5, 2010 at 07:49, Jonathan Gordon <jdgordy_at_gmail.com> wrote:

> I hit this issue with the recent android button handling reworking.
> not sending a BUTTON_REL is only a problem is the button can cause a
> context (screen) change. So, how can that happen with the scroll
> wheel?

If you reach end-of-playlist after having used the wheel, then
last_button in action.c is a wheel event, without a release. A long
long press on play/pause to stop playback can trigger it too (I'm
guessing due to queued repeat events from after the WPS has started
stopping), at least if an auto-bookmark is created.

But I just realized my patch only fixes the second case. Maybe
action.c needs to ignore wheel events in last_button in the if
statement I mentioned earlier...

-- 
  Magnus
Received on 2010-11-05

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa