Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: FS#6321 - Universal Image Viewer

Re: FS#6321 - Universal Image Viewer

From: Paul Louden <paulthenerd_at_gmail.com>
Date: Tue, 09 Nov 2010 15:25:27 -0600

On 11/9/2010 3:20 PM, Jonas Häggqvist wrote:
> On 09-11-2010 18:35, Marcin Bukat wrote:
>
>> BTW. Aren't viewers bind to particular file extensions? If so I
>> wouldn't bother to do
>> any more advanced detection. If someone rename .bmp to .jpg it's
>> his/her problem.
>
> The thing is that the image viewer lets you "browse" images on its
> own, so it has to do its own detection. Why not be smart about it
> rather than dumb?
>
"Of course it.s a .bmp, the image viewer opens it fine. So why doesn't
it work in my WPS?"

I think an error message saying "Image appears to be a .png" when a .bmp
is loaded with the magic numbers for a PNG, and possibly a refusal to
load it, makes some sense.

Being too intelligent and acting like nothing went wrong isn't really an
entirely positive behavior. At the very least the user should be let
know something isn't quite right.
Received on 2010-11-09


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa