Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: kugel: r28548 - in trunk: android/src/org/rockbox apps/gui/bitmap firmware/drivers firmware/export firmware/export/config firmware/target/hosted/android firmware/target/hosted/sdl

Re: kugel: r28548 - in trunk: android/src/org/rockbox apps/gui/bitmap firmware/drivers firmware/export firmware/export/config firmware/target/hosted/android firmware/target/hosted/sdl

From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Thu, 11 Nov 2010 16:26:18 +0100

On 11.11.2010 13:48, Maurus Cuelenaere wrote:
> Op 11-11-10 13:43, Björn Stenberg schreef:
>>> Op 11-11-10 12:18, Teruaki Kawashima schreef:
>>>>> +/* this are not actually the correct dimensions (480x272 is correct)
>>>>> + * should be fixed once there's a working LCD driver */
>>>>> +#define LCD_WIDTH 480
>>>>> +#define LCD_HEIGHT 272
>>>>> +#define LCD_DPI 128
>> Maurus Cuelenaere wrote:
>>> See [1], [2] and [3].
>> These links all say that 480x272 is correct. The comment says both
>> that 480x272 is correct _and_ that it is incorrect.
>>
>> If 480x272 is indeed the correct dimension, the comment should be
>> removed.
>
> So it should, this was probably a leftover from Thomas' original diff.
> I'll remove it unless someone beats me to it.
>

Right, I'm sorry. The comment is now incorrect. A previous version of
the patch maintained the incorrect dimensions but it was suggested to
just fix the dimensions while at it.

Best regards.
Received on 2010-11-11


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa