Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: moos: r28687 - in trunk/rbutil/rbutilqt: . lang

Re: moos: r28687 - in trunk/rbutil/rbutilqt: . lang

From: Mustapha Senhaji <moos75_at_gmail.com>
Date: Sun, 28 Nov 2010 13:12:24 +0000

Hello Dominik, my bad.

I'll revert those bits to restore the accelerator keys.

moos
-----Original Message-----
From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Sender: rockbox-dev-bounces_at_cool.haxx.se
Date: Sun, 28 Nov 2010 10:30:37
To: <rockbox-dev_at_cool.haxx.se>
Reply-To: Rockbox development <rockbox-dev_at_cool.haxx.se>
Subject: Re: moos: r28687 - in trunk/rbutil/rbutilqt: . lang

2010/11/28 <mailer_at_svn.rockbox.org>:
> Date: 2010-11-28 00:18:13 +0100 (Sun, 28 Nov 2010)
> New Revision: 28687
>
> Log Message:
> rbutil: Fix typos in french translation plus some minor changes (fix few typos on source strings too while I was here).

[...]

> -             <string>Pass&amp;word</string>
> +             <string>&amp;Password</string>

What's the reason for changing accelerator keys? This commit changes
various ones to ones that are already taken in the same widget. "P"
hasn't been used for "Password" since it's also used for "Port", and
if two fields use the same accelerator key pressing it the focus will
toggle between those. However, that is not how (at least I) expect it
to work. Or has there been a discussion about this that I missed? From
my point of view accelerator keys should be unique in their widget.
The issue is even worse on with "P" on the "Cache" settings page,
since it's not only used on that page but also for the "Proxy" name in
the tabs.

Since accelerator keys are also translated the translator has to take
care of not creating multiply used accelerator keys. If he thinks that
accelerator keys shouldn't be unique it's up to the translator to
ignore that in the translation, but that shouldn't affect the
untranslated strings.


 - Dominik
Received on 2010-11-28


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa