Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: teru: r28704 - trunk/apps/keymaps

Re: teru: r28704 - trunk/apps/keymaps

From: Marianne Arnold <m.arnold_at_telecolumbus.net>
Date: Mon, 29 Nov 2010 17:09:32 +0100

Am 29.11.2010 14:11, schrieb Jeff Goode:
> Good luck with that. Have you tested this change on all these targets?

I'm also curious (and admittedly doubtful) about this commit. The keymaps are a bit of a fragile construct, especially when one context links to another like it is the case here (which on the other hands saves duplication). I am afraid that this change broke something on at least some targets and I'm actually not too keen on trying.

There is a possibility that the action with release event was used in the list context and in the linked one(s) - before, the list context one would take precedence over the other in lists, now it is possible that the list context one (without the release event) hits first and then the other when the button is released, maybe getting you into trouble.

At least this change should have been put on flyspray first with a call for testers and probably a discussion on the mailing list before. I am also interested to know what the change should achieve as the commit message doesn't tell much. Could you explain?

Kind regards, Marianne
Received on 2010-11-29


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa