Re: jdgordon: r28714 - trunk/apps/gui/skin_engine

From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Wed, 1 Dec 2010 22:10:13 +0100

On Tue, Nov 30, 2010 at 23:15, Jonathan Gordon <jdgordy_at_gmail.com> wrote:

> strncmp was also used because otherwsie it was actually broken. I'm
> pretty sure the parser does not strip trailing spaces, so %if(foo, = ,
> bar) would get rejected. The mentioned speedup was more hopefully from
> it not checking every case once one was found.

I managed to miss the else's there. Sorry. :)

-- 
  Magnus

Received on 2010-12-01

Page was last modified "Jan 10 2012" The Rockbox Crew