Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Embedded albumart

Re: Embedded albumart

From: Paul Louden <paulthenerd_at_gmail.com>
Date: Sun, 13 Feb 2011 17:51:30 -0600

On 2/13/2011 5:42 PM, David Hall wrote:
>
> Dozen? Is that the bar?
> A - Yes.
> B - I have plenty of albums with far fewer tracks.
>
But the typical album is at least 9 or 10, isn't it? On many of our
players the virtual keyboard is almost impossibly to figure out just by
guessing.

>
> Have you given up on defending your edge case and now gone after
> attacking my desire and ability to use the virtual keyboard? For if we
> drop the edge case arguments what is the reason NOT to put the priority
> in my suggested order?

If we drop the edge case arguments, there's no reason not to do it
*either* way. Making that question pointless.

> Not possible within rockbox today, therefore not valid.
> Even if it was, an argument ago the virtual keyboard was too much work
> to rename a file but suddenly it's not too much work to use it to retag
> a file?

I think it was obvious I wasn't seriously suggesting it, but rather
saying that the virtual keyboard is pretty impractical for renaming even
a half dozen files in a timely manner and if we want to ask users,
realistically, to do that we may as well ask them to do other
impractical things.

> It is more of a solution than your priority scheme offers. I never
> claimed it was a compelling argument on its own, rather that it is a
> tiebreaker.

In my scheme you can fix it on the player in a single copy. In your
scheme it requires dozens. I'm not sure why yours is better.

For yours, you need to create a copy of folder.jpg for each individual
file that does not have embedded art, so that we can remove folder.jpg
and allow embedded art to work. In the case of an image in the parent
directory, this can mean dozens or hundreds of copies. For my scheme, I
need to create a copy of folder.jpg for each file *with* embedded AA, to
override it.

Since I've just realized both of ours can be fixed on player, and my
scheme requires less copies / time in vkeyboard (since you only need one
copy per bad song, instead of one copy per good song), I think we've
actually run out of things to argue about.
Received on 2011-02-14


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa